A random crash with v2.20.2

[4ster]

Please fill in this template when posting!
XMBC Version: v2.20.2
Installed or Portable version: Installed
Windows Version: 11 22H2
Mouse Information (brand/model): Logitech M705
Relevant Computer Information (CPU, RAM etc):
Did the problem occur after an upgrade of XMBC? (If so, from what version?): ?
Did the problem occur after a Windows update/upgrade? (If so, from what version?): ?
How long have you used XMBC?: Too long
What language and keyboard layout do you use in Windows?: En and 2 more

Clear description of the problem - try and include as much information as possible, including what button and mappings you are having problems with (if applicable).:

XMouse Button Control crashed, seemingly randomly while it's in the background. I have a crash dump as I configured my system to save those. I don't want to share it here since it contains personal information, but the stack trace is as following:

Code: Select all

...
bb 000000ff`f15f2c20 00007ff8`8d16d548     XMouseButtonHook!CLogger::LogDebug+0x161
bc 000000ff`f15f6f60 00007ff8`8d14939e     XMouseButtonHook!CThreadLock::CThreadLock+0x48
bd 000000ff`f15f6f90 00007ff8`8d14d0d1     XMouseButtonHook!CBrightness::SetOSD+0x240e
be 000000ff`f15f7000 00007ff8`8d16d548     XMouseButtonHook!CLogger::LogDebug+0x161
bf 000000ff`f15fb340 00007ff8`8d14939e     XMouseButtonHook!CThreadLock::CThreadLock+0x48
c0 000000ff`f15fb370 00007ff8`8d14d0d1     XMouseButtonHook!CBrightness::SetOSD+0x240e
c1 000000ff`f15fb3e0 00007ff8`8d16d755     XMouseButtonHook!CLogger::LogDebug+0x161
c2 000000ff`f15ff720 00007ff8`8d17875f     XMouseButtonHook!CThreadLock::TryEnterCS+0x85
c3 000000ff`f15ff750 00007ff8`dc7578e4     XMouseButtonHook!DisplayChanged+0x2a7f
c4 000000ff`f15ffa10 00007ff8`dc763863     user32!DispatchHookW+0x74
c5 000000ff`f15ffaa0 00007ff8`dcb72c94     user32!_fnHkINLPMSLLHOOKSTRUCT+0x33
c6 000000ff`f15ffb00 00007ff8`da5b1534     ntdll!KiUserCallbackDispatcherContinue
c7 000000ff`f15ffb98 00007ff8`dc75539a     win32u!NtUserGetMessage+0x14
c8 000000ff`f15ffba0 00007ff8`8d18fa6d     user32!GetMessageW+0x2a
c9 000000ff`f15ffc00 00007ff8`8d1a2f69     XMouseButtonHook!CheckVersionDays+0x506d
ca 000000ff`f15ffd90 00007ff8`db57269d     XMouseButtonHook!TestCrash+0x101f9
cb 000000ff`f15ffdc0 00007ff8`dcb2a9f8     kernel32!BaseThreadInitThunk+0x1d
cc 000000ff`f15ffdf0 00000000`00000000     ntdll!RtlUserThreadStart+0x28

Seems to be a stack overflow, and something with thread locks. I don't have symbols (do you publish pdb files?), but CLogger::LogDebug, CThreadLock::CThreadLock are identified correctly.

See also attached dump analysis.

[phil]

I don’t publish the pub’s but I do have them so I can share with you… I presume you didn’t get the crash catcher pop up to send the report to me?

I’m away this weekend but will try and reply some more tomorrow and send you the pdb’s as I have been trying to find this one for a while and this is the most useful info I’ve got so far!!!

[4ster]

No, I didn’t get the crash catcher pop up, perhaps because the crash was too severe for the popup to keep operating in the thread:
https://peteronprogramming.wordpress.co ... n-windows/

[phil]

OK Here are the PDB's and MAP files for 2.20.2
If you can use them to give something better than you have above great. If not, maybe you could send me the crash dump directly via email or PM?

https://1drv.ms/f/s!AveUNVCcurEcg5cI5xA ... w?e=KKNesL

Regards,
Phil

[4ster]

Here's the stack trace with the pdb info:

Code: Select all

...
bb 000000ff`f15f2c20 00007ff8`8d16d548     XMouseButtonHook!CLogger::LogDebug+0x161
bc 000000ff`f15f6f60 00007ff8`8d14939e     XMouseButtonHook!CThreadLock::CThreadLock+0x48
bd 000000ff`f15f6f90 00007ff8`8d14d0d1     XMouseButtonHook!CDebugLogQueue::PushDebugLog+0x3e
be 000000ff`f15f7000 00007ff8`8d16d548     XMouseButtonHook!CLogger::LogDebug+0x161
bf 000000ff`f15fb340 00007ff8`8d14939e     XMouseButtonHook!CThreadLock::CThreadLock+0x48
c0 000000ff`f15fb370 00007ff8`8d14d0d1     XMouseButtonHook!CDebugLogQueue::PushDebugLog+0x3e
c1 000000ff`f15fb3e0 00007ff8`8d16d755     XMouseButtonHook!CLogger::LogDebug+0x161
c2 000000ff`f15ff720 00007ff8`8d17875f     XMouseButtonHook!CThreadLock::TryEnterCS+0x85
c3 000000ff`f15ff750 00007ff8`dc7578e4     XMouseButtonHook!MouseHookLLProc+0x1c1f
c4 000000ff`f15ffa10 00007ff8`dc763863     user32!DispatchHookW+0x74
c5 000000ff`f15ffaa0 00007ff8`dcb72c94     user32!_fnHkINLPMSLLHOOKSTRUCT+0x33
c6 000000ff`f15ffb00 00007ff8`da5b1534     ntdll!KiUserCallbackDispatcherContinue
c7 000000ff`f15ffb98 00007ff8`dc75539a     win32u!NtUserGetMessage+0x14
c8 000000ff`f15ffba0 00007ff8`8d18fa6d     user32!GetMessageW+0x2a
c9 000000ff`f15ffc00 00007ff8`8d1a2f69     XMouseButtonHook!HookThreadProc+0x7ed
ca (Inline Function) --------`--------     XMouseButtonHook!invoke_thread_procedure+0xe [d:\th\minkernel\crts\ucrt\src\appcrt\startup\thread.cpp @ 82] 
cb 000000ff`f15ffd90 00007ff8`db57269d     XMouseButtonHook!thread_start<void (__cdecl*)(void * __ptr64)>+0x5d [d:\th\minkernel\crts\ucrt\src\appcrt\startup\thread.cpp @ 115] 
cc 000000ff`f15ffdc0 00007ff8`dcb2a9f8     kernel32!BaseThreadInitThunk+0x1d
cd 000000ff`f15ffdf0 00000000`00000000     ntdll!RtlUserThreadStart+0x28

Seems that essentially `LogDebug` calls itself recursively via the following call chain:
`CLogger::LogDebug` -> `CDebugLogQueue::PushDebugLog` -> `CThreadLock::CThreadLock` -> `CLogger::LogDebug` -> ...

Let me know if you need more information or the dump.

[phil]

Thats great - looks like a stack overflow in the logger, my bet is the logger is trying to log something! - oops...

[phil]

Yep, I think I found the problem now - thanks very much for the feedback - I've been struggling to locate this one for a few weeks - I could never make it go wrong here, probably because when Im debugging, it never goes near that code because its only active when debug logging is disabled (and was new in 2.20.2).... Makes so much sense now I know where it went wrong .

I've fixed it in 2.21 Beta 5, which I will release as 2.20.3 when Im happy its working and no other significant issues!

Regards,
Phil

[4ster]

Great, I'm glad that my report helped